[NativeRT] Cleanup Weights API #159052
Open
[NativeRT] Cleanup Weights API #159052
+3
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Clean up Weight class's API - Remove parameters() and buffers() - Rename attributes() to allValues() Test Plan: CI Rollback Plan: Reviewed By: zhxchen17 Differential Revision: D78871314
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159052
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 8 Unrelated FailuresAs of commit 622d933 with merge base abcb24f ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D78871314 |
zhxchen17
approved these changes
Jul 24, 2025
jingsh
approved these changes
Jul 24, 2025
henryoier
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Clean up Weight class's API
Test Plan:
CI
Rollback Plan:
Reviewed By: zhxchen17
Differential Revision: D78871314