symint attributes #159057
Draft
symint attributes #159057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159057
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit 70f74c3 with merge base 8460131 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D78747585 |
zou3519
reviewed
Jul 24, 2025
torch/nn/utils/stateless.py
Outdated
Comment on lines
106
to
108
| parameters_and_buffers_only = { | ||
| k: v for k, v in parameters_and_buffers.items() if isinstance(v, Tensor) | ||
| } |
There was a problem hiding this comment.
the nn stateless APIs should be allowed to override all attributes on an nn.Module, not just Tensors. cc @albanD
albanD
reviewed
Jul 24, 2025
torch/nn/utils/stateless.py
Outdated
Comment on lines
106
to
108
| parameters_and_buffers_only = { | ||
| k: v for k, v in parameters_and_buffers.items() if isinstance(v, Tensor) | ||
| } |
|
This pull request was exported from Phabricator. Differential Revision: D78747585 |
4ccbec5 to
ea25afd
Compare
avikchaudhuri
added a commit
to avikchaudhuri/pytorch
that referenced
this pull request
Jul 24, 2025
Summary: Pull Request resolved: pytorch#159057 Rollback Plan: Differential Revision: D78747585
Summary: Pull Request resolved: pytorch#159057 Rollback Plan: Differential Revision: D78747585
|
This pull request was exported from Phabricator. Differential Revision: D78747585 |
ea25afd to
70f74c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D78747585
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela