By @dcorbacho and me: introduce [cluster-]local shovels, adopt message containers for shovels #14256
+2,786
−279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansd
reviewed
Jul 22, 2025
This implementation intentionally ignores the drain property of AMQP 1.0 flow control because local shovels does not use this feature, and no external component can "enable" it, so we can simply ignore it. Pair: @dcorbacho. Co-authored-by: Diana Parra Corbacho <diana.parra-corbacho@broadcom.com> Co-authored-by: Michael Klishin <michaelklishin@icloud.com>
Fixes a dialyzer failure
CI uses a different hostname
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces several changes for shovels for
4.2.0:mcmodulerabbit_queue_type) and the AMQP 1.0-inspired consumer and publisher side implementations that avoid using an AMQP 1.0 or AMQP 0-9-1 Erlang clientCluster-Local Shovel Type
This PR introduces a new shovel "protocol":
local. Instead of using an AMQP 1.0 or AMQP 0-9-1 Erlang client for consuming and re-publishing the messages, this shovel implementationuses various internal API modules, namely
rabbit_queue_type, and can skip network serialization and cross-protocol message conversion.For this reason, this shovel protocol can only be used to with a source or destination in the same cluster. However, the other part of shovel can still use AMQP 1.0 or AMQP 0-9-1.
A shovel can use the
localprotocol on both sides within the same cluster.Message Containers for Message Translation
This is self-explanatory: adopt the
mcmodule.AMQP 1.0 Message Immutability: a Potentially Breaking Change
AMQP 1.0 shovels modified message application property, even though it arguably should not.
Instead, we modify message annotations. This is a potentially breaking change: a number of metadata fields have been renamed.
shovelled-by=>x-opt-shovelled-byshovel-type=>x-opt-shovel-typeshovel-name=>x-opt-shovel-name