Request to pull with minor improvement #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 13, 2017 13:46
the lock while sleep() doesn't release any lock while waiting.
michaelklishin
approved these changes
Sep 13, 2017
|
Thank you! |
|
@2sbsbsb can you please make the same change to the website version? (note that I linked to the |
|
@michaelklishin sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Bug) - channel is made final so that it can be used inside the inner anonymous local instance of Consumer.
(Improvement) - Replaced sleep() with wait().
Wait() is much better than sleep. Relevant difference is that it release the lock while sleep doesn't.
Ref - https://stackoverflow.com/questions/1036754/difference-between-wait-and-sleep