Make group.id required for Consumer creation(confluentinc#472) (confluentinc#506)

Ryan P · web-flow · commit ab161a3193bd · 2018-12-10T14:11:02.000-05:00
diff --git a/confluent_kafka/src/Consumer.c b/confluent_kafka/src/Consumer.c
@@ -1387,6 +1387,7 @@ static int Consumer_init (PyObject *selfobj, PyObject *args, PyObject *kwargs) {
         rd_kafka_poll_set_consumer(self->rk);
 
         self->u.Consumer.rkqu = rd_kafka_queue_get_consumer(self->rk);
+        assert(self->u.Consumer.rkqu);
 
         return 0;
 }
@@ -1423,8 +1424,8 @@ PyTypeObject ConsumerType = {
         "\n"
         ".. py:function:: Consumer(config)\n"
         "\n"
-        "  :param dict config: Configuration properties. At a minimum ``bootstrap.servers`` and "
-        "``group.id`` **should** be set"
+        "  :param dict config: Configuration properties. At a minimum ``group.id`` **must** be set,"
+                " ``bootstrap.servers`` **should** be set"
         "\n"
         "Create new Consumer instance using provided configuration dict.\n"
         "\n"
diff --git a/confluent_kafka/src/confluent_kafka.c b/confluent_kafka/src/confluent_kafka.c
@@ -1629,6 +1629,15 @@ rd_kafka_conf_t *common_conf_setup (rd_kafka_type_t ktype,
                 PyDict_Update(confdict, kwargs);
         }
 
+        if (ktype == RD_KAFKA_CONSUMER && 
+                !PyDict_GetItemString(confdict, "group.id")) {
+
+                PyErr_SetString(PyExc_ValueError,
+                                "Failed to create consumer: group.id must be set");
+                Py_DECREF(confdict);
+                return NULL;
+        }
+
 	conf = rd_kafka_conf_new();
 
         /*
diff --git a/tests/test_Consumer.py b/tests/test_Consumer.py
@@ -313,3 +313,11 @@ def test_calling_store_offsets_after_close_throws_erro():
     with pytest.raises(RuntimeError) as ex:
         c.offsets_for_times([TopicPartition("test", 0)])
     assert 'Consumer closed' == str(ex.value)
+
+
+def test_consumer_withot_groupid():
+    """ Consumer should raise exception if group.id is not set """
+
+    with pytest.raises(ValueError) as ex:
+        Consumer({'bootstrap.servers': "mybroker:9092"})
+    assert 'group.id must be set' in str(ex)
diff --git a/tests/test_misc.py b/tests/test_misc.py
@@ -155,7 +155,8 @@ def test_unordered_dict(init_func):
     """
     Interceptor configs can only be handled after the plugin has been loaded not before.
     """
-    client = init_func({'confluent.monitoring.interceptor.publishMs': 1000,
+    client = init_func({'group.id': 'test-group',
+                        'confluent.monitoring.interceptor.publishMs': 1000,
                         'confluent.monitoring.interceptor.sessionDurationMs': 1000,
                         'plugin.library.paths': 'monitoring-interceptor',
                         'confluent.monitoring.interceptor.topic': 'confluent-kafka-testing',
