Support static allocation in Freertos example #651
+53
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on raspberrypi/pico-sdk#2436 |
lurch
reviewed
Jun 19, 2025
lurch
reviewed
Jun 19, 2025
213f979 to
1eb7e37
Compare
1eb7e37 to
6207c40
Compare
kilograham
reviewed
Jul 23, 2025
| @@ -1,3 +1,4 @@ | |||
| # Example running FreeRTOS on 1 core | |||
There was a problem hiding this comment.
This CMakeLists.txt is a bit inimidating; could we maybe
- get rid of the ${TARGET_NAME} stuff and just inline the value
- move all the PICO_CYW43_SUPPORTED to a single IF at the bottom
There was a problem hiding this comment.
Also pre-existing but can we call this hello_freertos_one_core / hello_freertos_two_cores, or hello_freertos/hello_freertos_smp
Note also, worth checking if we usually list multiple targets in the top level README
There was a problem hiding this comment.
finally, it feels a bit like example overload to have async_context stuff in here, but i guess it can stay for now
kilograham
reviewed
Jul 23, 2025
| #if configSUPPORT_STATIC_ALLOCATION | ||
| static StackType_t async_context_freertos_task_stack[WORKER_TASK_STACK_SIZE]; | ||
| config.task_stack = async_context_freertos_task_stack; | ||
| #endif | ||
| if (!async_context_freertos_init(&async_context_instance, &config)) | ||
| return NULL; | ||
| return &async_context_instance.core; |
There was a problem hiding this comment.
I know this is pre-existing, but it is confusing to have pico_ prefixes here and on pico_init_led
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.