Add cache expiration support (TTL) #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsor
reviewed
Jun 8, 2018
README.md
Outdated
| @@ -55,15 +57,25 @@ This example fetches the value of the key `foo` and passes it to the | |||
|
|
|||
| #### set() | |||
|
|
|||
| The `set(string $key, mixed $value, ?float $ttl = null): PromiseInterface` method can be used to | |||
| stores an item in the cache. | |||
README.md
Outdated
| The `set(string $key, mixed $value, ?float $ttl = null): PromiseInterface` method can be used to | ||
| stores an item in the cache. | ||
|
|
||
| This method will resolve with a true on success or false when an error |
|
@jsor Good catch, updated! |
jsor
approved these changes
Jun 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for cache expiry (TTL). This is a new feature for most consumers, but this is also a BC break because it adds a new parameter to the
CacheInterface::set($name, $value, $ttl = null)signature.As its name implies, the
ArrayCacheuses an array to store the optional TTL and will yield a cache miss when a cache item is expired.Builds on top of #28, thank you @WyriHaximus for the initial version! I've squashed the original version to a single commit to preserve authorship. Unlike the initial version, this updated version uses an array for significantly faster operation (heavily inspired by reactphp/event-loop#164).
Supersedes / closes #28
Resolves / closes #11