Documentation and examples for advanced usage #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
reviewed
Jul 2, 2017
README.md
Outdated
| @@ -92,6 +93,31 @@ $dns = $factory->createCached('8.8.8.8', $loop, $cache); | |||
|
|
|||
| See also the wiki for possible [cache implementations](https://github.com/reactphp/react/wiki/Users#cache-implementations). | |||
|
|
|||
| ## Advanced Usage | |||
|
|
|||
| For more advanced usages one can utilize the `Executor` directly. | |||
There was a problem hiding this comment.
I'm planning to deprecate the Executor in future versions, so perhaps we should link to the whole namespace instead (may keep the below example in place though)?
There was a problem hiding this comment.
Deprecating executor seems to be a good idea.
clue
reviewed
Jul 2, 2017
README.md
Outdated
| @@ -13,6 +13,7 @@ easily be used to create a DNS server. | |||
| * [Basic usage](#basic-usage) | |||
| * [Caching](#caching) | |||
| * [Custom cache adapter](#custom-cache-adapter) | |||
| * [Advanced usage](#advance-usage) | |||
clue
approved these changes
Aug 9, 2017
|
Changes LGTM, unrelated build error has been addressed via #68 in the meantime |
jsor
approved these changes
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently once can use the
Executordirectly to query but this isn't documented. This PR adds documentation and an example.