Skip to content

Forward compatibility with PHPUnit 6 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2017
Merged

Forward compatibility with PHPUnit 6 #85

merged 2 commits into from
Dec 1, 2017

Conversation

carusogabriel
Copy link
Contributor

@carusogabriel carusogabriel commented Nov 13, 2017 •
edited
Loading

As did in others Reactphp repos, I use the PHPUnit\Framework\TestCase notation instead of PHPUnit_Framework_TestCase while extending our TestCases. This helped us migrate to PHPUnit 6, that no longer support snake case class names.

I just need to bump PHPUnit version to ^4.8.35 and ^5.7, that support this namespace.

@carusogabriel
Copy link
Contributor Author

Ok, we are facing some issues with this update. I have some solutions, and I want your opinion:

  • Just update to PHPUnit 5, because PHPUnit has big breaking changes;
  • Drop PHPUnit 4 support, but require minimum PHP 5.6;

@clue
Copy link
Member

clue commented Nov 18, 2017

@Gabriel-Caruso Thanks for keeping up with this! I've updated reactphp/socket#133 to add a very simple BC layer to support all PHPUnit versions, perhaps you can look into implementing a similar logic here? 👍

@carusogabriel
Copy link
Contributor Author

@clue Actually, no, because there's no setExpectedMessage method for PHPUnit 4. What should we do?

@clue
Copy link
Member

clue commented Nov 19, 2017

@Gabriel-Caruso Not sure I follow, have you seen the setExpectedException() BC layer from the above PR (https://github.com/reactphp/socket/pull/133/files#diff-d4c8c6dc8769324fc27cfdac19f05cafR85)? This works out of the box on PHPUnit 4 and will redirect to new method calls on newer versions of PHPUnit.

@carusogabriel
Copy link
Contributor Author

carusogabriel commented Nov 19, 2017 •
edited
Loading

@clue Done, everything is working now 🎉

@clue clue changed the title Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase Forward compatibility with PHPUnit 6 Nov 19, 2017
clue
clue approved these changes Nov 19, 2017
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping up with this, changes LGTM! :shipit: 👍

@clue clue added this to the v0.4.12 milestone Nov 19, 2017
jsor
jsor reviewed Nov 20, 2017
View reviewed changes
@carusogabriel
Copy link
Contributor Author

Anything else that should be done here?

@WyriHaximus
Copy link
Member

Nope LGTM 👍

@jsor jsor merged commit 9d38e3c into reactphp:master Dec 1, 2017
@carusogabriel carusogabriel deleted the phpunit branch December 1, 2017 13:26
@clue clue mentioned this pull request Jan 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelunik kelunik kelunik left review comments

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v0.4.12
Development

Successfully merging this pull request may close these issues.
5 participants
@carusogabriel @clue @WyriHaximus @jsor @kelunik
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy