add config option to ExtEventLoop to support readable streams via FEA…

…TURE_FDS
reactphp · cboden · Sep 6, 2014 · Aug 20, 2014 · Aug 20, 2014 · Aug 20, 2014
commit e4d6c7b3adf25410c3dc302463bbd96bf59275bc
diff --git a/src/ExtEventLoop.php b/src/ExtEventLoop.php
@@ -4,6 +4,7 @@
 
 use Event;
 use EventBase;
+use EventConfig as EventBaseConfig;
 use React\EventLoop\Tick\FutureTickQueue;
 use React\EventLoop\Tick\NextTickQueue;
 use React\EventLoop\Timer\Timer;
@@ -27,9 +28,9 @@ class ExtEventLoop implements LoopInterface
     private $writeListeners = [];
     private $running;
 
-    public function __construct()
+    public function __construct(EventBaseConfig $config = null)
     {
-        $this->eventBase = new EventBase();
+        $this->eventBase = new EventBase($config);
         $this->nextTickQueue = new NextTickQueue($this);
         $this->futureTickQueue = new FutureTickQueue($this);
         $this->timerEvents = new SplObjectStorage();

diff --git a/tests/ExtEventLoopTest.php b/tests/ExtEventLoopTest.php
@@ -6,7 +6,12 @@
 
 class ExtEventLoopTest extends AbstractLoopTest
 {
-    public function createLoop()
+    public function setUp()
+    {
+        $this->loop = $this->createLoop();
+    }
+
+    public function createLoop($readStreamCompatible = false)
     {
         if ('Linux' === PHP_OS && !extension_loaded('posix')) {
             $this->markTestSkipped('libevent tests skipped on linux due to linux epoll issues.');
@@ -16,7 +21,13 @@ public function createLoop()
             $this->markTestSkipped('ext-event tests skipped because ext-event is not installed.');
         }
 
-        return new ExtEventLoop();
+        $cfg = null;
+        if($readStreamCompatible) {
+            $cfg = new \EventConfig();
+            $cfg->requireFeatures(\EventConfig::FEATURE_FDS);
+        }
+
+        return new ExtEventLoop($cfg);
     }
 
     public function createStream()
@@ -56,4 +67,25 @@ public function writeToStream($stream, $content)
 
         fwrite($stream, $content);
     }
+
+    /**
+     * @group epoll-readable-error
+     */
+    public function testCanUseReadableStreamWithFeatureFds()
+    {
+        $this->loop = $this->createLoop(true);
+
+        $input = fopen('php://temp/maxmemory:0', 'r+');
+
+        fwrite($input, 'x');
+        ftruncate($input, 0);
+
+        $this->loop->addReadStream($input, $this->expectCallableExactly(2));
+
+        $this->writeToStream($input, "foo\n");
+        $this->loop->tick();
+
+        $this->writeToStream($input, "bar\n");
+        $this->loop->tick();
+    }
 }