Skip to content

[RFC] Remove all callable type hints for consistency and performance reasons #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/ExtEventLoop.php
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ function ($signal) {
$this->createStreamCallback();
}

public function addReadStream($stream, callable $listener)
public function addReadStream($stream, $listener)
{
$key = (int) $stream;

Expand All @@ -77,7 +77,7 @@ public function addReadStream($stream, callable $listener)
}
}

public function addWriteStream($stream, callable $listener)
public function addWriteStream($stream, $listener)
{
$key = (int) $stream;

Expand Down Expand Up @@ -124,7 +124,7 @@ private function removeStream($stream)
}
}

public function addTimer($interval, callable $callback)
public function addTimer($interval, $callback)
{
$timer = new Timer($interval, $callback, false);

Expand All @@ -133,7 +133,7 @@ public function addTimer($interval, callable $callback)
return $timer;
}

public function addPeriodicTimer($interval, callable $callback)
public function addPeriodicTimer($interval, $callback)
{
$timer = new Timer($interval, $callback, true);

Expand All @@ -150,17 +150,17 @@ public function cancelTimer(TimerInterface $timer)
}
}

public function futureTick(callable $listener)
public function futureTick($listener)
{
$this->futureTickQueue->add($listener);
}

public function addSignal($signal, callable $listener)
public function addSignal($signal, $listener)
{
$this->signals->add($signal, $listener);
}

public function removeSignal($signal, callable $listener)
public function removeSignal($signal, $listener)
{
$this->signals->remove($signal, $listener);
}
Expand Down
14 changes: 7 additions & 7 deletions src/ExtLibevLoop.php
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ function ($signal) {
);
}

public function addReadStream($stream, callable $listener)
public function addReadStream($stream, $listener)
{
if (isset($this->readEvents[(int) $stream])) {
return;
Expand All @@ -79,7 +79,7 @@ public function addReadStream($stream, callable $listener)
$this->readEvents[(int) $stream] = $event;
}

public function addWriteStream($stream, callable $listener)
public function addWriteStream($stream, $listener)
{
if (isset($this->writeEvents[(int) $stream])) {
return;
Expand Down Expand Up @@ -115,7 +115,7 @@ public function removeWriteStream($stream)
}
}

public function addTimer($interval, callable $callback)
public function addTimer($interval, $callback)
{
$timer = new Timer( $interval, $callback, false);

Expand All @@ -134,7 +134,7 @@ public function addTimer($interval, callable $callback)
return $timer;
}

public function addPeriodicTimer($interval, callable $callback)
public function addPeriodicTimer($interval, $callback)
{
$timer = new Timer($interval, $callback, true);

Expand All @@ -157,17 +157,17 @@ public function cancelTimer(TimerInterface $timer)
}
}

public function futureTick(callable $listener)
public function futureTick($listener)
{
$this->futureTickQueue->add($listener);
}

public function addSignal($signal, callable $listener)
public function addSignal($signal, $listener)
{
$this->signals->add($signal, $listener);
}

public function removeSignal($signal, callable $listener)
public function removeSignal($signal, $listener)
{
$this->signals->remove($signal, $listener);
}
Expand Down
14 changes: 7 additions & 7 deletions src/ExtLibeventLoop.php
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function ($signal) {
$this->createStreamCallback();
}

public function addReadStream($stream, callable $listener)
public function addReadStream($stream, $listener)
{
$key = (int) $stream;

Expand All @@ -95,7 +95,7 @@ public function addReadStream($stream, callable $listener)
}
}

public function addWriteStream($stream, callable $listener)
public function addWriteStream($stream, $listener)
{
$key = (int) $stream;

Expand Down Expand Up @@ -144,7 +144,7 @@ private function removeStream($stream)
}
}

public function addTimer($interval, callable $callback)
public function addTimer($interval, $callback)
{
$timer = new Timer($interval, $callback, false);

Expand All @@ -153,7 +153,7 @@ public function addTimer($interval, callable $callback)
return $timer;
}

public function addPeriodicTimer($interval, callable $callback)
public function addPeriodicTimer($interval, $callback)
{
$timer = new Timer($interval, $callback, true);

Expand All @@ -174,17 +174,17 @@ public function cancelTimer(TimerInterface $timer)
}
}

public function futureTick(callable $listener)
public function futureTick($listener)
{
$this->futureTickQueue->add($listener);
}

public function addSignal($signal, callable $listener)
public function addSignal($signal, $listener)
{
$this->signals->add($signal, $listener);
}

public function removeSignal($signal, callable $listener)
public function removeSignal($signal, $listener)
{
$this->signals->remove($signal, $listener);
}
Expand Down
14 changes: 7 additions & 7 deletions src/LoopInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ interface LoopInterface
* @param callable $listener Invoked when the stream is ready.
* @see self::removeReadStream()
*/
public function addReadStream($stream, callable $listener);
public function addReadStream($stream, $listener);

/**
* [Advanced] Register a listener to be notified when a stream is ready to write.
Expand Down Expand Up @@ -106,7 +106,7 @@ public function addReadStream($stream, callable $listener);
* @param callable $listener Invoked when the stream is ready.
* @see self::removeWriteStream()
*/
public function addWriteStream($stream, callable $listener);
public function addWriteStream($stream, $listener);

/**
* Remove the read event listener for the given stream.
Expand Down Expand Up @@ -178,7 +178,7 @@ public function removeWriteStream($stream);
*
* @return TimerInterface
*/
public function addTimer($interval, callable $callback);
public function addTimer($interval, $callback);

/**
* Enqueue a callback to be invoked repeatedly after the given interval.
Expand Down Expand Up @@ -248,7 +248,7 @@ public function addTimer($interval, callable $callback);
*
* @return TimerInterface
*/
public function addPeriodicTimer($interval, callable $callback);
public function addPeriodicTimer($interval, $callback);

/**
* Cancel a pending timer.
Expand Down Expand Up @@ -314,7 +314,7 @@ public function cancelTimer(TimerInterface $timer);
*
* @return void
*/
public function futureTick(callable $listener);
public function futureTick($listener);

/**
* Register a listener to be notified when a signal has been caught by this process.
Expand Down Expand Up @@ -356,7 +356,7 @@ public function futureTick(callable $listener);
*
* @return void
*/
public function addSignal($signal, callable $listener);
public function addSignal($signal, $listener);

/**
* Removes a previously added signal listener.
Expand All @@ -372,7 +372,7 @@ public function addSignal($signal, callable $listener);
*
* @return void
*/
public function removeSignal($signal, callable $listener);
public function removeSignal($signal, $listener);

/**
* Run the event loop until there are no more tasks to perform.
Expand Down
6 changes: 3 additions & 3 deletions src/SignalsHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ final class SignalsHandler
private $on;
private $off;

public function __construct(LoopInterface $loop, callable $on, callable $off)
public function __construct(LoopInterface $loop, $on, $off)
{
$this->loop = $loop;
$this->on = $on;
Expand All @@ -30,7 +30,7 @@ public function __destruct()
}
}

public function add($signal, callable $listener)
public function add($signal, $listener)
{
if (count($this->signals) == 0 && $this->timer === null) {
/**
Expand All @@ -53,7 +53,7 @@ public function add($signal, callable $listener)
$this->signals[$signal][] = $listener;
}

public function remove($signal, callable $listener)
public function remove($signal, $listener)
{
if (!isset($this->signals[$signal])) {
return;
Expand Down
14 changes: 7 additions & 7 deletions src/StreamSelectLoop.php
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ function ($signal) {
);
}

public function addReadStream($stream, callable $listener)
public function addReadStream($stream, $listener)
{
$key = (int) $stream;

Expand All @@ -100,7 +100,7 @@ public function addReadStream($stream, callable $listener)
}
}

public function addWriteStream($stream, callable $listener)
public function addWriteStream($stream, $listener)
{
$key = (int) $stream;

Expand Down Expand Up @@ -130,7 +130,7 @@ public function removeWriteStream($stream)
);
}

public function addTimer($interval, callable $callback)
public function addTimer($interval, $callback)
{
$timer = new Timer($interval, $callback, false);

Expand All @@ -139,7 +139,7 @@ public function addTimer($interval, callable $callback)
return $timer;
}

public function addPeriodicTimer($interval, callable $callback)
public function addPeriodicTimer($interval, $callback)
{
$timer = new Timer($interval, $callback, true);

Expand All @@ -153,12 +153,12 @@ public function cancelTimer(TimerInterface $timer)
$this->timers->cancel($timer);
}

public function futureTick(callable $listener)
public function futureTick($listener)
{
$this->futureTickQueue->add($listener);
}

public function addSignal($signal, callable $listener)
public function addSignal($signal, $listener)
{
if ($this->pcntl === false) {
throw new \BadMethodCallException('Event loop feature "signals" isn\'t supported by the "StreamSelectLoop"');
Expand All @@ -167,7 +167,7 @@ public function addSignal($signal, callable $listener)
$this->signals->add($signal, $listener);
}

public function removeSignal($signal, callable $listener)
public function removeSignal($signal, $listener)
{
$this->signals->remove($signal, $listener);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Tick/FutureTickQueue.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public function __construct()
*
* @param callable $listener The callback to invoke.
*/
public function add(callable $listener)
public function add($listener)
{
$this->queue->enqueue($listener);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Timer/Timer.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ final class Timer implements TimerInterface
* @param callable $callback The callback that will be executed when this timer elapses
* @param bool $periodic Whether the time is periodic
*/
public function __construct($interval, callable $callback, $periodic = false)
public function __construct($interval, $callback, $periodic = false)
{
if ($interval < self::MIN_INTERVAL) {
$interval = self::MIN_INTERVAL;
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy