Skip to content

Run tests on Windows using AppVeyor (backported to v0.4) #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

clue
Copy link
Member

@clue clue commented Feb 13, 2017

Backported #76 (originally by @WyriHaximus) to the v0.4 release branch so that tests also work here.

@clue clue added this to the v0.4.3 milestone Feb 13, 2017
@clue
Copy link
Member Author

clue commented Feb 13, 2017

@WyriHaximus Do the build errors on AppVeyor make any sense to you? Should this be fixed here or should we just accept this despite the build errors?

@WyriHaximus
Copy link
Member

@clue no clue, it's windows so it fails at times sadly enough. But you could try restarting the build. The JSON parse errors or very vague. You could remove the cache directive or change it to .json as we don't have a .lock. My bad, should have done that while filing the initial PR for AppVeyor

@clue
Copy link
Member Author

clue commented Feb 13, 2017

I've now triggered a rebuild several times already, but the build keeps failing at different places all the time... 😕

@WyriHaximus
Copy link
Member

Gah 😕

@clue
Copy link
Member Author

clue commented Feb 13, 2017

If you look at the build history, you'll see that EVERY build failed, except the one where you've added AppVeyor :-) It even failed merging these changes to the master branch.

https://ci.appveyor.com/project/clue/event-loop/history

What should we do here? Not a big fan of marking working code as broken, so we should either look into fixing this ASAP or remove AppVeyor again?

@WyriHaximus
Copy link
Member

Looks like 7.x is the most consistent failure. We could try removing it from the matrix and otherwise ditch AppVeyor all together.

@jsor
Copy link
Member

jsor commented Feb 13, 2017

I've have absolutely no idea what's going on there and as long as we don't have someone who can reliably maintain the AppVeyor configuration, i'd vote for removing it alltogether.

@WyriHaximus
Copy link
Member

My main reason for doing this was #71 and if we can't do that reliable we should indeed remove it. For personal projects I have less of an issue with failing some jobs on windows. But for react we can't afford that because it's time consuming to baby sit all the builds.

@clue
Copy link
Member Author

clue commented Feb 13, 2017

I have to agree here 👍

I'd rather test on Windows manually and fix any issues as they occur.

FWIW, AppVeyor did NOT help reproducing the error from #71, it actually passed, so...

@WyriHaximus Can you file a PR that supersedes this and #76?

@WyriHaximus
Copy link
Member

@clue so I've just file a reverse PR: #79
@clue can you also ditch the webhook and delete the project on AppVeyor so it doesn't sneak up on us again?

@clue clue deleted the appveyor branch February 13, 2017 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy