Skip to content

StreamSelectLoop: Int overflow for big timer intervals #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

StreamSelectLoop: Int overflow for big timer intervals #96

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9021dc8
Add StreamSelectLoop time conversion methods.
ivkalita Apr 5, 2017
8279d9b
Change StreamSelectLoop to keep timeout in seconds, replace usleep wi…
ivkalita Apr 5, 2017
4400ede
Fix StreamSelectLoopTest::testSmallTimerInterval to expect nanoseconds.
ivkalita Apr 5, 2017
08c709b
Add StreamSelectLoop test for PHP_INT_MAX seconds timer interval.
ivkalita Apr 5, 2017
4347fa3
Change StreamSelectLoop::streamSelect null-timeout handling.
ivkalita Apr 10, 2017
3c8a5d6
Add explanation about StreamSelectLoop::getSeconds int overflow worka…
ivkalita Apr 11, 2017
bb81383
Move StreamSelectLoop::streamSelect micro- and nanoseconds calculatio…
ivkalita Apr 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix StreamSelectLoopTest::testSmallTimerInterval to expect nanoseconds.
  • Loading branch information
@ivkalita
ivkalita committed Apr 5, 2017
commit 4400ede5ca298ea86c653045effb1a8bc5f6726c
10 changes: 5 additions & 5 deletions tests/StreamSelectLoopTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,15 +156,15 @@ protected function forkSendSignal($signal)
public function testSmallTimerInterval()
{
/** @var StreamSelectLoop|\PHPUnit_Framework_MockObject_MockObject $loop */
$loop = $this->getMock('React\EventLoop\StreamSelectLoop', ['streamSelect']);
$loop = $this->getMock('React\EventLoop\StreamSelectLoop', ['sleep']);
$loop
->expects($this->at(0))
->method('streamSelect')
->with([], [], 1);
->method('sleep')
->with(0, intval(Timer::MIN_INTERVAL * StreamSelectLoop::NANOSECONDS_PER_SECOND));
$loop
->expects($this->at(1))
->method('streamSelect')
->with([], [], 0);
->method('sleep')
->with(0, 0);

$callsCount = 0;
$loop->addPeriodicTimer(Timer::MIN_INTERVAL, function() use (&$loop, &$callsCount) {
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy