The Server should always have a request listener
#122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsor
approved these changes
Feb 17, 2017
|
Rebased now that #125 is in |
jsor
approved these changes
Feb 20, 2017
WyriHaximus
approved these changes
Feb 20, 2017
See #131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having an HTTP server with no
requestlistener does not really make any sense at all.Currently, the
end()call actually results in an invalid HTTP response stream, because it sends a closing chunk (chunked transfer encoding) without actually sending any HTTP response headers.This simple PR changes it so that this case will simply not be handled at all, so that the client never receives any response data at all. This is actually in line with how our Socket component works if there's no
connectionlistener.Note that the invalid response stream will that is sent by
end()will be addressed in a separate ticket, I'll link to this here once it's ready.