Raise maximum request header size to 8k to match common implementations #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cboden
approved these changes
Nov 21, 2017
jsor
approved these changes
Nov 21, 2017
WyriHaximus
approved these changes
Nov 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current maximum request header size is rather small and can easily be reached by using long URIs or long cookie values. This simple PR raises the default maximum request header size from 4k to 8k to match other common implementations, such as Apache, nginx etc. (https://stackoverflow.com/questions/686217/maximum-on-http-header-values or http://nginx.org/en/docs/http/ngx_http_core_module.html#large_client_header_buffers).
This is currently a hard-coded default with no way to change this value as a consumer. There's another open issue #214 to give users more control over this. This PR is created in the hope to spare users from looking into this in the first place.