Skip to content

Mark StreamingServer final #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2017
Merged

Mark StreamingServer final #283

merged 1 commit into from
Dec 12, 2017

Conversation

WyriHaximus
Copy link
Member

With Server marked as final, StreamingServer should be marked final as well

@WyriHaximus WyriHaximus added this to the v0.8.0 milestone Dec 12, 2017
@WyriHaximus WyriHaximus requested review from jsor and clue December 12, 2017 00:38
@clue clue added the BC break label Dec 12, 2017
clue
clue approved these changes Dec 12, 2017
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes perfect sense! :shipit:

@clue clue merged commit 337fc08 into reactphp:master Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
BC break easy pick help wanted maintenance
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@WyriHaximus @jsor @clue
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy