Small code improvements #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
requested changes
Dec 28, 2017
src/Io/ServerRequest.php
Outdated
| use RingCentral\Psr7\Request; | ||
| use InvalidArgumentException; |
There was a problem hiding this comment.
It looks like these imports aren't used anywhere?
There was a problem hiding this comment.
Actually, constructor has @throws annotation. My IDE (PHPStorm) highlights it with undefined class InvalidArgumentException. I've removed import and added root namespace to annotation.
| @@ -17,7 +17,6 @@ | |||
| * */ | |||
| class CloseProtectionStream extends EventEmitter implements ReadableStreamInterface | |||
| { | |||
| private $connection; | |||
There was a problem hiding this comment.
Good catch! Apparently, this should be replaced with $input which is used in the constructor 👍
e03f56a to
742a015
Compare
742a015 to
ceba730
Compare
|
@clue I've updated the request according to your comments |
clue
approved these changes
Dec 28, 2017
jsor
approved these changes
Dec 29, 2017
WyriHaximus
approved these changes
Dec 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides some small code improvement: