Skip to content

Replace PHPUnit's getMock() for forward compatibility #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nopolabs
Copy link
Contributor

@nopolabs nopolabs commented Feb 6, 2017

per comment in reactphp/event-loop#68 (comment)
with respect of replacing usage of getMock to avoid deprecation warnings with newer versions
of phpunit

Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaict this isn't really needed now that #92 is in, but it doesn't do any harm and I guess this makes sense for forward compatibility anyway 👍

@clue clue changed the title replace getMock for forward compatibility Replace PHPUnit's getMock() for forward compatibility Feb 6, 2017
@clue clue merged commit 38cc193 into reactphp:master Feb 6, 2017
@WyriHaximus WyriHaximus added this to the v0.4.3 milestone Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy