Skip to content

Documentation for Client (and advanced Connector) #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2018
Merged

Documentation for Client (and advanced Connector) #121

merged 1 commit into from
Feb 5, 2018

Conversation

clue
Copy link
Member

@clue clue commented Feb 5, 2018 •
edited
Loading

This simple PR adds documentation for the Client class and how an explicit instance of ConnectorInterface can be passed to it.

Refs #46

@clue clue added this to the v0.5.7 milestone Feb 5, 2018
WyriHaximus
WyriHaximus requested changes Feb 5, 2018
View reviewed changes
README.md Outdated
)
));

$client = new Client($loop);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$connector missing here? :P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting, updated :shipit:

@WyriHaximus WyriHaximus requested a review from jsor February 5, 2018 18:57
@WyriHaximus WyriHaximus merged commit 924baa2 into reactphp:master Feb 5, 2018
@clue clue deleted the client-docs branch February 7, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
easy pick maintenance
Projects
None yet
Milestone
v0.5.7
Development

Successfully merging this pull request may close these issues.
3 participants
@clue @jsor @WyriHaximus
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy