Changed $stream from DuplexStreamInterface to ReadableStreamInterface in Response constructor #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
requested changes
Sep 24, 2016
| @@ -108,7 +107,6 @@ public function close(\Exception $error = null) | |||
| $this->emit('end', array($error, $this)); | |||
|
|
|||
| $this->removeAllListeners(); | |||
| $this->stream->end(); | |||
There was a problem hiding this comment.
Shouldn't the underlying stream be close()d here?
|
Ping @clue, done the requested change |
clue
reviewed
Oct 6, 2016
| @@ -25,7 +24,7 @@ class Response implements ReadableStreamInterface | |||
| private $headers; | |||
| private $readable = true; | |||
|
|
|||
| public function __construct(DuplexStreamInterface $stream, $protocol, $version, $code, $reasonPhrase, $headers) | |||
| public function __construct(ReadableStreamInterface $stream, $protocol, $version, $code, $reasonPhrase, $headers) | |||
There was a problem hiding this comment.
👍
For the reference only: This change preserves BC because you can still pass in a DuplexStreamInterface because it also implements the ReadableStreamInterface.
|
LGTM 👍 |
clue
approved these changes
Oct 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on #62 (comment)
Supersedes #62
Solves #61