Skip to content

Replace Factory with Client constructor #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,7 @@ Interesting events emitted by Response:
<?php

$loop = React\EventLoop\Factory::create();

$dnsResolverFactory = new React\Dns\Resolver\Factory();
$dnsResolver = $dnsResolverFactory->createCached('8.8.8.8', $loop);

$factory = new React\HttpClient\Factory();
$client = $factory->create($loop, $dnsResolver);
$client = new React\HttpClient\Client($loop);

$request = $client->request('GET', 'https://github.com/');
$request->on('response', function ($response) {
Expand Down
1 change: 0 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"php": ">=5.4.0",
"guzzlehttp/psr7": "^1.0",
"react/socket": "^0.7",
"react/dns": "0.4.*",
"react/event-loop": "0.4.*",
"react/stream": "0.4.*",
"react/promise": "~2.2",
Expand Down
9 changes: 2 additions & 7 deletions examples/01-google.php
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
<?php

use React\HttpClient\Factory;
use React\HttpClient\Client;
use React\HttpClient\Response;

require __DIR__ . '/../vendor/autoload.php';

$loop = React\EventLoop\Factory::create();

$resolverFactory = new React\Dns\Resolver\Factory();
$resolver = $resolverFactory->create('8.8.8.8', $loop);

$factory = new Factory();
$client = $factory->create($loop, $resolver);
$client = new Client($loop);

$request = $client->request('GET', 'https://google.com/');

Expand Down
9 changes: 2 additions & 7 deletions examples/02-post-json.php
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
<?php

use React\HttpClient\Factory;
use React\HttpClient\Client;
use React\HttpClient\Response;

require __DIR__ . '/../vendor/autoload.php';

$loop = React\EventLoop\Factory::create();

$resolverFactory = new React\Dns\Resolver\Factory();
$resolver = $resolverFactory->create('8.8.8.8', $loop);

$factory = new Factory();
$client = $factory->create($loop, $resolver);
$client = new Client($loop);

$data = json_encode(array('result' => 42));

Expand Down
9 changes: 2 additions & 7 deletions examples/03-streaming.php
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
<?php

use React\HttpClient\Factory;
use React\HttpClient\Client;
use React\HttpClient\Response;

require __DIR__ . '/../vendor/autoload.php';

$loop = React\EventLoop\Factory::create();

$resolverFactory = new React\Dns\Resolver\Factory();
$resolver = $resolverFactory->create('8.8.8.8', $loop);

$factory = new Factory();
$client = $factory->create($loop, $resolver);
$client = new Client($loop);

$request = $client->request('GET', 'http://httpbin.org/drip?duration=5&numbytes=5&code=200');

Expand Down
8 changes: 7 additions & 1 deletion src/Client.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,20 @@

namespace React\HttpClient;

use React\EventLoop\LoopInterface;
use React\Socket\ConnectorInterface;
use React\Socket\Connector;

class Client
{
private $connector;

public function __construct(ConnectorInterface $connector)
public function __construct(LoopInterface $loop, ConnectorInterface $connector = null)
{
if ($connector === null) {
$connector = new Connector($loop);
}

$this->connector = $connector;
}

Expand Down
19 changes: 0 additions & 19 deletions src/Factory.php

This file was deleted.

pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy