Reduced promises depth test #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@woodongwong thanks for looking into this 👍 For now you can raise your @clue @WyriHaximus what do you think about this? |
SimonFrings
approved these changes
Oct 6, 2021
clue
approved these changes
Oct 6, 2021
There was a problem hiding this comment.
@woodongwong Small change, but noticeable improvement with PHP's default configuration, thank you for looking into this! 
jsor
approved these changes
Oct 6, 2021
WyriHaximus
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I execute phpunit, it prompts me
Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 20480 bytes), which I know I can fix by modifying php.ini. I think I can reduce the promises depth, i.e. I can not modify the memory_limit (default 128M) and also ensure the correct test, thanks. (very sorry, English is not my native language)