Skip to content

[2.x] Fix legacy HHVM build by downgrading Composer #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

SimonFrings
Copy link
Member

Builds on top of the work done by @clue and the discussion inside reactphp/socket#289.

I also updated the path for the CI badge.

@SimonFrings SimonFrings changed the title Fix legacy HHVM build by downgrading Composer [2.x] Fix legacy HHVM build by downgrading Composer Apr 12, 2022
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for applying the changes here as well! :shipit:

Also good to see the same changes backported to v1 via #218 and especially the fact this isn't needed for Promise v3 due to #138! 👍

@clue clue requested a review from WyriHaximus April 13, 2022 07:03
@clue clue added this to the v2.10.0 milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy