Skip to content

Implement Eventloop based on pecl/event #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

csaoh
Copy link

@csaoh csaoh commented Apr 17, 2013

Fix #161

The tests are failing for now, I submitted an issue about it: https://bugs.php.net/bug.php?id=64652

@romainneutron
Copy link
Member

The ticket seems closed :) https://bugs.php.net/bug.php?id=64652

@csaoh
Copy link
Author

csaoh commented Apr 17, 2013

I will still need to remove all the php://temp from AbstractLoopTest, since it's not supported yet.

@romainneutron
Copy link
Member

Is this an @rosmanov statement ? The seg fault is fixed, but no support for in-memory streams ?

@csaoh
Copy link
Author

csaoh commented Apr 17, 2013

Yep, on the ticket page:

 [2013-04-17 19:08 UTC] osmanov@php.net
However, php://temp stream is not yet supported. I'll try to provide support for it later.

@csaoh
Copy link
Author

csaoh commented Apr 22, 2013

I just made this implementation work with @cboden's test script referenced in #167

@cboden
Copy link
Member

cboden commented Jul 21, 2013

Almost all the unit tests error'ed out with:

Event::add(): Epoll ADD(1) on fd 54 failed. Old events were 0; read change was 1 (add); write change was 0 (none): Operation not permitted

I installed pecl/event version 1.7.0 via pecl install event

@rosmanov
Copy link

Almost all the unit tests error'ed out with:

Event::add(): Epoll ADD(1) on fd 54 failed. Old events were 0; read change was 1 (add); write change was 0 (none): Operation not permitted

Could you provide a sample code snippet? Probably, the fd is a regular file descriptor(not a FIFO, or a pipe thing).

@cboden
Copy link
Member

cboden commented Jul 21, 2013

That's correct. The unit test for EventLoop is using files.

@cboden
Copy link
Member

cboden commented Jul 21, 2013

Doing a real-world test using sockets and it did work better. I did get a Segmentation fault (core dumped) when attempting to send 4MB through the client.

@rosmanov
Copy link

Doing a real-world test using sockets and it did work better. I did get a Segmentation fault (core dumped) when attempting to send 4MB through the client.

Again, I'd like to see a simple code snippet, which doesn't require any Framework, for instance. Otherwise it's rather difficult to reproduce and fix.

@rosmanov
Copy link

Did it work with older versions of "event" ext.?

@cboden
Copy link
Member

cboden commented Jul 21, 2013

This is the only version I have tested. Is there an older version you'd like me to test with?

I'll try to put together a raw failing example.

@rosmanov
Copy link

1.6.2 please http://pecl.php.net/package/event/1.6.2
and/or 1.6.1

@cboden
Copy link
Member

cboden commented Jul 21, 2013

Tested, 1.6.2 also has the same issues.

@rosmanov
Copy link

Good. It means that I didn't break anything in the recent releases. Waiting for a sample snippet then.

@cboden
Copy link
Member

cboden commented Jan 26, 2014

Closing in favour of #248

@cboden cboden closed this Jan 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new event pecl package
4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy