Skip to content

Articles Section #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2017
Merged

Articles Section #2

merged 2 commits into from
Feb 7, 2017

Conversation

WyriHaximus
Copy link
Member

Supersedes reactphp/website#9. Added 3 articles under the components listing, looking like this:
3ej5x7t

@WyriHaximus WyriHaximus requested review from jsor, cboden and clue February 5, 2017 21:02
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree we should somehow link to articles, I'm undecided if the homepage is the best place for this.

Also, I think styling these like our own components may be confusing / misleading.

What do you think about this?

@jsor
Copy link
Member

jsor commented Feb 7, 2017

Since this is just a readonly POC i'm merging everything so we have the contents. We can decide later how and where it will be presented.

@jsor jsor merged commit c8fb081 into reactphp:master Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy