Skip to content

Fix forward compatibility with upcoming EventLoop releases in tests #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2017

Conversation

clue
Copy link
Member

@clue clue commented Oct 8, 2017

This fixes a small oversight from #104: The test suite still used the deprecated tick() method which will be removed in the upcoming EventLoop release.

Builds on top of #104

@clue clue added this to the v0.8.5 milestone Oct 8, 2017
@WyriHaximus WyriHaximus merged commit 8a58745 into reactphp:master Oct 8, 2017
@andig
Copy link
Contributor

andig commented Oct 11, 2017

@clue
Copy link
Member Author

clue commented Oct 11, 2017

@andig Duh! Thanks for spotting, see #127 :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy