Skip to content

fix: partially revert callout icon behavior #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jul 17, 2025
Merged

fix: partially revert callout icon behavior #1154

merged 19 commits into from
Jul 17, 2025

Conversation

runnabro
Copy link
Member

@runnabro runnabro commented Jul 16, 2025 •
edited
Loading

PR App Fix RM-XYZ

🧰 Changes

Bringing back floats when we render icons + some new styling for legacy project rendering

PagerDuty before:
Incident Priority-20250716-134208@2x

After:
Incident Priority-20250716-134150@2x

natwest before:
Integration guide-20250716-134226@2x

After:
Integration guide-20250716-134219@2x

🧬 QA & Testing

@runnabro runnabro requested a review from a team July 16, 2025 20:42
@runnabro runnabro marked this pull request as ready for review July 16, 2025 20:42
kellyjosephprice
kellyjosephprice approved these changes Jul 16, 2025
View reviewed changes
Copy link
Collaborator

@kellyjosephprice kellyjosephprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this looks good to you!

@runnabro runnabro merged commit 58781b7 into next Jul 17, 2025
7 checks passed
@runnabro runnabro deleted the partial-revert-callouts branch July 17, 2025 18:45
rafegoldberg pushed a commit that referenced this pull request Jul 17, 2025
@semantic-release-bot
build(release): 🚀 v10.2.0 🦉
75fc589 
## Version 10.2.0
### ✨ New & Improved

* allow empty icon in jsx ([#1155](#1155)) ([4818ac6](4818ac6))

### 🛠 Fixes & Updates

* cleanup ([#1156](#1156)) ([6e64fbb](6e64fbb))
* partially revert callout icon behavior ([#1154](#1154)) ([58781b7](58781b7))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v10.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellyjosephprice kellyjosephprice kellyjosephprice approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@runnabro @rafegoldberg @kellyjosephprice
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy