Skip to content

logger fix and improvements #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2016
Merged

logger fix and improvements #1059

merged 1 commit into from
May 27, 2016

Conversation

jeevatkm
Copy link
Contributor

This PR is fix and code improvements around #1055. Revel already has support for configuring log flags via app.conf, I have just set sensible default for it. How it will look like-

dev mode: (same as v0.12 release)

INFO  2016/05/25 18:22:50 revel.go:355: Loaded module static
INFO  2016/05/25 18:22:50 revel.go:355: Loaded module testrunner
INFO  2016/05/25 18:22:50 revel.go:220: Initialized Revel v0.13.0-dev (TBD) for >= go1.4
INFO  2016/05/25 18:22:50 run.go:57: Running logger (reveltest.com/logger) in dev mode
INFO  2016/05/25 18:22:50 harness.go:170: Listening on :9000
...
...
INFO  2016/05/25 18:22:57 main.go:30: Running revel server
Go to /@tests to run the tests.
Listening on :59681...

prod mode: (Improvement with sensible defaults for log flags)

...
INFO  2016/05/25 18:23:14 Loaded module static
INFO  2016/05/25 18:23:14 Initialized Revel v0.13.0-dev (TBD) for >= go1.4
INFO  2016/05/25 18:23:14 Running revel server
INFO  2016/05/25 18:23:14 Skipping routes for inactive module testrunner
Listening on :9000...

Request Access Log:
Format: RequestStartTime ClientIP ResponseStatus RequestLatency HTTPMethod URLPath

2016/05/25 18:17:17.806 127.0.0.1 200  162.269µs GET /
2016/05/25 18:17:17.810 127.0.0.1 200  204.896µs GET /public/css/bootstrap.css
2016/05/25 18:17:17.811 127.0.0.1 200  108.862µs GET /public/js/jquery-1.9.1.min.js

@jeevatkm jeevatkm added type-bug topic-log effort-minutes Will take up to 60 minutes to implement priority-should sooner rather than later type-enhancement New enhancement of existing feature labels May 26, 2016
@jeevatkm jeevatkm added this to the v0.13 milestone May 26, 2016
@jeevatkm jeevatkm self-assigned this May 26, 2016
@jeevatkm jeevatkm merged commit 5a25be0 into develop May 27, 2016
@jeevatkm jeevatkm added type-feature New feature request and removed type-enhancement New enhancement of existing feature labels Jun 5, 2016
@jeevatkm jeevatkm deleted the logger-fix branch June 7, 2016 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jeevatkm jeevatkm

Labels
effort-minutes Will take up to 60 minutes to implement priority-should sooner rather than later topic-log type-bug type-feature New feature request
Projects
None yet
Milestone
v0.13
Development

Successfully merging this pull request may close these issues.
1 participant
@jeevatkm
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy