Changes to revel to support a template engine architecture #1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02f0f5e to
0e865cc
Compare
brendensoares
requested changes
May 19, 2017
template_engine.go
Outdated
| ) | ||
|
|
||
| type TemplateEngine interface { | ||
| // #ParseAndAdd: prase template string and add template to the set. |
There was a problem hiding this comment.
remove # since they do nothing in godoc output
template.go
Outdated
| Content() []string // Content | ||
| // #Render: Called by the server to render the template out the io.Writer, args contains the arguements to be passed to the template. | ||
| // arg: wr io.Writer | ||
| // arg: arg interface{} | ||
| Render(wr io.Writer, arg interface{}) error |
template_adapter_go.go
Outdated
| // The functions available for use in the templates. | ||
| TemplateFuncs = map[string]interface{}{ | ||
| "url": ReverseURL, | ||
| "set": func(renderArgs map[string]interface{}, key string, value interface{}) template.JS { |
There was a problem hiding this comment.
viewArgs or context or contextArgs?
f92f97d to
adf488a
Compare
brendensoares
requested changes
May 31, 2017
template_engine.go
Outdated
| Event(event int, arg interface{}) | ||
|
|
||
| // returns true if this engine should be used to parse the file specified in baseTemplate | ||
| IsEngineFor(engine TemplateEngine, templateView *TemplateView) bool |
Closed
5bb78e2 to
0ad63f9
Compare
brendensoares
approved these changes
Jun 6, 2017
revel.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| // RevelImportPath Revel framework import path | ||
| RevelImportPath = "github.com/revel/revel" | ||
| ) | ||
| const ( | ||
| // Called when templates are going to be refreshed (receivers are registered template engines added to the template.engine conf option) | ||
| TEMPLATE_REFRESH = iota |
There was a problem hiding this comment.
TEMPLATE_REFRESH_REQUESTED?
revel.go
Outdated
| // Called when templates are going to be refreshed (receivers are registered template engines added to the template.engine conf option) | ||
| TEMPLATE_REFRESH = iota | ||
| // Called when templates are refreshed (receivers are registered template engines added to the template.engine conf option) | ||
| TEMPLATE_REFRESH_COMPLETE |
There was a problem hiding this comment.
TEMPLATE_REFRESH_COMPLETED?
Deprecated TemplateLoader.Template - Replaced with TemplateLoader.TemplateLang (old function still exists for backwards compatibility) Renamed TemplateEngine interface "IsEngineFor" to "Handles"
730a190 to
6dd3fbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds template engine support