@notzippy can you please provide steps to verify that this works from a new app to the expected results?

Please & thank you.

Steps, I create a module called bar and add a messages/test.en file to it to translate helloworld. Note this just adds <b>A friendly {{msg . "helloworld"}}</b> to the created view in the application, in the real world messages in the module should be normally only used in that module.

revel new temp/foo
mkdir -p $GOPATH/src/temp/foo/modules/bar/messages
echo "helloworld=Hi there"> $GOPATH/src/temp/foo/modules/bar/messages/test.en
echo "module.bar=temp/foo/modules/bar" >>$GOPATH/src/temp/foo/conf/app.conf
echo "<b>A friendly {{msg . \"helloworld\"}}</b>" >> $GOPATH/src/temp/foo/app/views/App/Index.html 
revel run temp/foo prod

(Had to run in production mode since the module is appended to the production section of the app.conf)

Additional notes,

1. It is expected that the developer follow the same guidelines with the messages as they would with the views, ie prefix all the messages with something appropriate which would not conflict with another message since these are appended to the "global" message queue

So, here is a short summary:
Revel can import from modules (http://revel.github.io/manual/modules.html):

1. templates
2. controllers
3. routes
4. assets (using Static.ServeModule method).
   This PR makes it possible to import i18n files, too. @notzippy Is my understanding correct?

casting @pedromorgan

Yes this allows modules to declare there own 18n messages. I was not aware
that routes could be defined in a module, how does one so that?

On Fri, Jan 2, 2015, 6:41 AM anonx notifications@github.com wrote:

So, here is a short summary:
Revel can import from modules (
http://revel.github.io/manual/modules.html):

1. templates
2. controllers
3. routes
4. assets (using Static.ServeModule method).
   This PR makes it possible to import i18n files, too. @notzippy
   https://github.com/notzippy Is my understanding correct?

cast @pedromorgan https://github.com/pedromorgan

—
Reply to this email directly or view it on GitHub
#828 (comment).

@notzippy To import routes from the module, update your app's config/routes: https://github.com/revel/revel/blob/master/samples/booking/conf/routes#L5 or #422.

@AnonX @notzippy importing module routes is in the Revel manual under "Routing Modules".

@brendensoares @AnonX thx, learn something new every day...

@brendensoares Can u merge the develop branch into master ASAP, people are referinging stuff.. and we need to go!!!!!!!!!!!!

or shall i commit to master myself.. he thinks !!!

@pedromorgan what do you mean "referinging stuff"?

Don't merge into master, that would break our workflow. The Roadmap for v0.12 has been reduced, we just need to finish it up and then we can merge into master and release develop. There isn't much effort needed before we can release v0.12.

Will this make the 0.12 release ? Or will it be deferred till later ?

@notzippy No, this PR is not the correct way to go about loading i18n files in modules.

We can still use this PR, but we need to make some changes.

TODO

• Track a MessagesPath in revel.go's func addModule(name, importPath, modulePath string) that i18n.go can search for messages files.

I'm rescheduling this for the next release as we don't have time to update this PR and reverify it. v0.12 needs to get buttoned up and out the door.

@brendensoares We are using Modules directly in static module BTW: https://github.com/revel/revel/blob/master/modules/static/app/controllers/static.go#L66
The only difference is here messages are scanned once (on bootstrap time). And static is iterating over modules on every request which is not really cool if we have many modules.

@brendensoares Why is it important to store the messagesPath ? After the message dictionary is built is there any need for the path to be stored ? Perhaps if I understood the usefulness of this it would make more sense.

@AnonX @notzippy I'm thinking that we have a user configurable MessagesPath that is searched for message files. We may also have a single user configurable flag, such as SearchModulesForMessages, that would then adds all detected modules' path to MessagesPath.

"Separation of Concerns" seems like a good pattern to follow in general and this is an opportunity to use it. Agreed?

Thanks @notzippy and @jeevatkm for feedback.