-
Notifications
You must be signed in to change notification settings - Fork 383
feat: add support for multiple databases with ActiveRecord #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Is there a way we can test this? Please also include a changelog entry :) |
I updated the changelog entry. I have no idea how to test it, but if you have an idea I can implement it. |
@aried3r How much do you care about test coverage for this, considering the difficulty in setting up multiple databases in CI? |
I haven't yet needed to test multi-db Rails setups on CI myself, so I have to ask naively, shouldn't it be – at least for PostgreSQL – "just" another call do I don't want to test Rails itself, but if there was even a single test that confirms that two DBs are being used, I'd appreciate it. Could we also add a little bit of documentation to the README? |
Any plans to merge this to master? |
@n-studio Hey, sorry for the delay! Do you think you could:
Until those things are completed, I'm going to put this in draft state just to indicate that there's work to be done before a final review. |
fixes #10
https://guides.rubyonrails.org/active_record_multiple_databases.html