Release gem on GitHub #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's move this out into a separate change, a-lá #696 |
I updated Ruby to 3.2 because it's much easier to compile 3.2+ than 3.1 on my machine. I also locked pg gem to help my use bundle install.
2dd60ce to
8e8db8b
Compare
|
Removed. I kept the Ruby 3.2 and MySQL updates to help me in development. Feel free to remove it if you were thinking of something else. |
benlangfeld
approved these changes
Nov 28, 2024
|
I'm afraid I just couldn't get this to work. https://github.com/rpush/rpush/actions/runs/12072998016/job/33668193629 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #692
This should help release the gem on GitHub. When release, you can dispatch the release workflow on GitHub Actions. Choose "Release" workflow, and run it. The workflow will:
rpush/version.rb.v<version>. e.g.,v9.2.0.Because the release workflow uses an action called
rubygems/release-gem, to publish the gem via GitHub, the gem owners must configure the "Trusted publishing". You must add GitHub as a trusted platform.Other changes:
pg,mysql2to resolve a few build problems on my development environment.tests.ymlto run the latest Ubuntu. This can be further improved to use GitHub repo's ruleset to set certain or all tests must pass for PR to be able to merge. Happy to help on this area too.