Skip to content

fix: module cache missing in runtime requirements #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

fix: module cache missing in runtime requirements #24

merged 1 commit into from
Apr 15, 2025

Conversation

LingyuCoder
Copy link
Contributor

fix web-infra-dev/rspack#10011

the runtime of react refresh plugin use __webpack_require__.c here but it may not in runtime requirements. so we should add it in hooks

@LingyuCoder LingyuCoder requested a review from ahabhgk April 15, 2025 03:32
@Austaras
Copy link

For reference https://github.com/pmmmwh/react-refresh-webpack-plugin/blob/main/lib/index.js#L199

@LingyuCoder LingyuCoder merged commit af9b3fe into main Apr 15, 2025
4 checks passed
@LingyuCoder LingyuCoder deleted the fix/module-cache-requirement branch April 15, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: rspack would crash using vanilla extract with react refresh
3 participants
@LingyuCoder @Austaras @ahabhgk
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy