Skip to content

Migrate to GitHub Actions #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 16, 2020
Merged

Migrate to GitHub Actions #44

merged 8 commits into from
Apr 16, 2020

Conversation

Tiryoh
Copy link
Contributor

@Tiryoh Tiryoh commented Apr 13, 2020 •
edited
Loading

will close #42

@Tiryoh Tiryoh marked this pull request as ready for review April 13, 2020 08:11
@Tiryoh Tiryoh force-pushed the #42_add_github_actions branch from 450602c to b2dbf8c Compare April 13, 2020 08:12
@Tiryoh Tiryoh marked this pull request as draft April 13, 2020 08:19
@Tiryoh Tiryoh self-assigned this Apr 13, 2020
@Tiryoh Tiryoh force-pushed the #42_add_github_actions branch from 40a23c0 to 6d19dd3 Compare April 13, 2020 09:31
@Tiryoh Tiryoh force-pushed the #42_add_github_actions branch from 6d19dd3 to b097d47 Compare April 13, 2020 09:32
@Tiryoh Tiryoh requested a review from ShotaAk April 14, 2020 03:06
@Tiryoh Tiryoh assigned ShotaAk and unassigned Tiryoh Apr 14, 2020
@Tiryoh Tiryoh marked this pull request as ready for review April 14, 2020 03:07
@Tiryoh Tiryoh added the Type: CI Changes to CI configuration files and scripts label Apr 14, 2020
ShotaAk
ShotaAk suggested changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

チェックしました。コメントを残したので確認お願いします。

キャッシュ機能については後ほど追加で良いと思います。（挑戦した痕跡が見えたので）

@Tiryoh
Copy link
Contributor Author

Tiryoh commented Apr 15, 2020 •
edited
Loading

キャッシュについてはあまり効果が見られなかったので一度削除しました。今までとは異なり、ドライバ以外（サンプルプログラム等）の更新ではこのテストは走らないので、キャッシュが必要そうであれば今後検討したいと思います。

キャッシュあり：https://github.com/rt-net/RaspberryPiMouse/runs/582341544
キャッシュなし：https://github.com/rt-net/RaspberryPiMouse/runs/584337873

@Tiryoh Tiryoh requested a review from ShotaAk April 15, 2020 10:16
@ShotaAk
Copy link
Contributor

ShotaAk commented Apr 16, 2020

キャッシュしても5分しか変わらないのか・・・

ShotaAk
ShotaAk approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良いと思います

@ShotaAk ShotaAk merged commit eb76e9a into master Apr 16, 2020
@Tiryoh Tiryoh deleted the #42_add_github_actions branch April 16, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShotaAk ShotaAk ShotaAk approved these changes

Assignees

@ShotaAk ShotaAk

Labels
Type: CI Changes to CI configuration files and scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub Actionsへの移行
2 participants
@Tiryoh @ShotaAk
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy