Skip to content

Refactor install script and support Raspberry Pi 4 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2020
Merged

Refactor install script and support Raspberry Pi 4 #62

merged 2 commits into from
Dec 15, 2020

Conversation

Tiryoh
Copy link
Contributor

@Tiryoh Tiryoh commented Dec 7, 2020 •
edited
Loading

What does this implement/fix?

  • ビルド成功時でも"ERROR"の文字列を含むログが出力され、誤解を招きます。エラーが出なければ最小限の出力となるように変更しています。
  • コメントと改行を追加してスクリプトを見やすくしています。
  • Raspberry Pi 4の場合は自動でrtmouse.c内のオプションを書き換えるようにしています。
$ ./utils/build_install.bash 
make -C /usr/src/linux-headers-5.4.0-1023-raspi M=/home/ubuntu/RaspberryPiMouse/src/drivers V=0 clean
make[1]: Entering directory '/usr/src/linux-headers-5.4.0-1023-raspi'
  CLEAN   /home/ubuntu/RaspberryPiMouse/src/drivers
  CLEAN   /home/ubuntu/RaspberryPiMouse/src/drivers/Module.symvers
make[1]: Leaving directory '/usr/src/linux-headers-5.4.0-1023-raspi'
make -C /usr/src/linux-headers-5.4.0-1023-raspi M=/home/ubuntu/RaspberryPiMouse/src/drivers V=0 modules
make[1]: Entering directory '/usr/src/linux-headers-5.4.0-1023-raspi'
  CC [M]  /home/ubuntu/RaspberryPiMouse/src/drivers/rtmouse.o
  Building modules, stage 2.
  MODPOST 1 modules
  CC [M]  /home/ubuntu/RaspberryPiMouse/src/drivers/rtmouse.mod.o
  LD [M]  /home/ubuntu/RaspberryPiMouse/src/drivers/rtmouse.ko
make[1]: Leaving directory '/usr/src/linux-headers-5.4.0-1023-raspi'

Does this close any currently open issues?

いいえ

How has this been tested?

Raspberry Pi Mouse実機にて動作確認をしています。

Any other comments?

Checklists

  • I have read the CONTRIBUTING guidelines.
  • I have checked to ensure there aren't other open Pull Requests for the same change.

@Tiryoh Tiryoh added Type: Refactoring A code change that neither fixes a bug nor adds a feature Type: Feature New Feature and removed Type: Refactoring A code change that neither fixes a bug nor adds a feature labels Dec 7, 2020
@Tiryoh Tiryoh requested a review from ShotaAk December 7, 2020 06:52
ShotaAk
ShotaAk reviewed Dec 14, 2020
View reviewed changes
Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raspberry Pi 4 と、Ubuntu 18.04 & Raspbian (10) で動作確認しました。
良いと思います。

１箇所修正お願いします。

@Tiryoh
Fix indentation
bd967bc 
Co-authored-by: Shota Aoki <s.aoki@rt-net.jp>
@Tiryoh Tiryoh requested a review from ShotaAk December 15, 2020 01:59
@ShotaAk ShotaAk merged commit a9af4fa into master Dec 15, 2020
@ShotaAk ShotaAk deleted the feature/raspi4-install-script branch December 15, 2020 05:08
@Tiryoh Tiryoh mentioned this pull request Dec 15, 2020
Closed
4 tasks
@Tiryoh Tiryoh mentioned this pull request Jan 16, 2021
Merged
2 tasks
@Tiryoh Tiryoh mentioned this pull request May 10, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShotaAk ShotaAk ShotaAk approved these changes

Assignees

@ShotaAk ShotaAk

Labels
Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tiryoh @ShotaAk
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy