[Fix #2121] Allow space before values in hash literals in ExtraSpacing #2233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| ## master (unreleased) | |||
|
|
|||
| * [#2121](https://github.com/bbatsov/rubocop/issues/2121): Allow space before values in hash literals in `Style/ExtraSpacing` to avoid correction conflict. ([@jonas054][]) | |||
There was a problem hiding this comment.
The section heading is missing.
362e3a6 to
2bd924f
Compare
|
Added heading and fixed failing tests. |
2bd924f to
2fef45c
Compare
|
Rebased. |
…aSpacing Leave the spacing before values to the AlignHash cop. Avoid infinite correction loops between AlignHash and ExtraSpacing.
2fef45c to
ae56019
Compare
|
@bbatsov Have you had a chance to take another look? |
bbatsov
added a commit
that referenced
this pull request
Sep 13, 2015
[Fix #2121] Allow space before values in hash literals in ExtraSpacing
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leave the spacing before values to the
AlignHashcop. Avoid infinite correction loops betweenAlignHashandExtraSpacing.