[Fix #1228] Enhance Rails/SaveBang to properly handle instance variables
#1421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Jan 19, 2025
lib/rubocop/cop/rails/save_bang.rb
Outdated
Comment on lines
331
to
333
| assignment = assignable_node(node).parent | ||
| assignment&.lvasgn_type? | ||
|
|
||
| assignment&.ivasgn_type? || assignment&.lvasgn_type? |
There was a problem hiding this comment.
Can you refactor to the following?
diff --git a/lib/rubocop/cop/rails/save_bang.rb b/lib/rubocop/cop/rails/save_bang.rb
index 2729c762c..b60598a4e 100644
--- a/lib/rubocop/cop/rails/save_bang.rb
+++ b/lib/rubocop/cop/rails/save_bang.rb
@@ -328,9 +328,9 @@ module RuboCop
end
def return_value_assigned?(node)
- assignment = assignable_node(node).parent
+ return false unless (assignment = assignable_node(node).parent)
- assignment&.ivasgn_type? || assignment&.lvasgn_type?
+ assignment.ivasgn_type? || assignment.lvasgn_type?
end
def persist_method?(node, methods = RESTRICT_ON_SEND)7487f40 to
5030b42
Compare
|
Can you add a changelog entry file? |
koic
reviewed
Jan 19, 2025
lib/rubocop/cop/rails/save_bang.rb
Outdated
| assignment&.lvasgn_type? | ||
| return false unless (assignment = assignable_node(node).parent) | ||
|
|
||
| assignment.ivasgn_type? || assignment.lvasgn_type? |
There was a problem hiding this comment.
Could it be that it’s not limited solely to adding instance variables?
Suggested change
| assignment.ivasgn_type? || assignment.lvasgn_type? | |
| assignment.assignment? |
5cb703b to
bf0dc58
Compare
Earlopain
reviewed
Jan 19, 2025
| @@ -0,0 +1 @@ | |||
| * [#1228](https://github.com/rubocop/rubocop-rails/issues/1228): Enhance `Rails/SaveBang` to properly handle instance variables. ([@ydakuka][]) | |||
There was a problem hiding this comment.
This file is missing the .md extension and I think it will not be picked up by the changelog generator because of that
bf0dc58 to
48233de
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1228
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.