Skip to content

Commit 9b41c2a

Browse files
committed
Do not define test method instead of skip when Calendar class is not defined.
Revisit r34739. Patch by MSP-Greg. [Bug #14088][ruby-core:83690][fix GH-1743] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60734 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
1 parent 61e4c99 commit 9b41c2a

File tree

4 files changed

+5
-17
lines changed

4 files changed

+5
-17
lines changed

test/date/test_date_attr.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ def test__wday_predicate
8888
end
8989

9090
def test_nth_kday
91-
skip unless Date.new.respond_to?(:nth_kday?, true)
9291
assert_equal(false, Date.new(2001,1,14).__send__(:nth_kday?, 1,0))
9392
assert_equal(true, Date.new(2001,1,14).__send__(:nth_kday?, 2,0))
9493
assert_equal(false, Date.new(2001,1,14).__send__(:nth_kday?, 3,0))
@@ -99,6 +98,6 @@ def test_nth_kday
9998
assert_equal(true, Date.new(2001,1,14).__send__(:nth_kday?, -3,0))
10099
assert_equal(false, Date.new(2001,1,14).__send__(:nth_kday?, -4,0))
101100
assert_equal(false, Date.new(2001,1,14).__send__(:nth_kday?, -5,0))
102-
end
101+
end if Date.new.respond_to?(:nth_kday?, true)
103102

104103
end

test/date/test_date_base.rb

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ def test__inf
5454
end
5555

5656
def test_ordinal__julian
57-
skip unless defined?(Calendar)
5857
for j in @from..@to
5958
m, d, y = julian_from_absolute(absolute_from_julian_day_number(j))
6059
j0 = julian_day_number_from_absolute(absolute_from_julian(12, 31, y - 1))
@@ -69,7 +68,6 @@ def test_ordinal__julian
6968
end
7069

7170
def test_ordinal__gregorian
72-
skip unless defined?(Calendar)
7371
for j in @from..@to
7472
m, d, y = gregorian_from_absolute(absolute_from_julian_day_number(j))
7573
j0 =
@@ -85,7 +83,6 @@ def test_ordinal__gregorian
8583
end
8684

8785
def test_civil__julian
88-
skip unless defined?(Calendar)
8986
for j in @from..@to
9087
m, d, y = julian_from_absolute(absolute_from_julian_day_number(j))
9188
j2 = julian_day_number_from_absolute(absolute_from_julian(m, d, y))
@@ -100,7 +97,6 @@ def test_civil__julian
10097
end
10198

10299
def test_civil__gregorian
103-
skip unless defined?(Calendar)
104100
for j in @from..@to
105101
m, d, y = gregorian_from_absolute(absolute_from_julian_day_number(j))
106102
j2 = julian_day_number_from_absolute(absolute_from_gregorian(m, d, y))
@@ -115,7 +111,6 @@ def test_civil__gregorian
115111
end
116112

117113
def test_commercial__gregorian
118-
skip unless defined?(Calendar)
119114
for j in @from..@to
120115
w, d, y = iso_from_absolute(absolute_from_julian_day_number(j))
121116
j2 = julian_day_number_from_absolute(absolute_from_iso(w, d, y))
@@ -130,7 +125,6 @@ def test_commercial__gregorian
130125
end
131126

132127
def test_weeknum
133-
skip unless defined?(Calendar)
134128
for j in @from..@to
135129
for k in 0..1
136130
wy, ww, wd = Date.__send__(:jd_to_weeknum, j, k, Date::GREGORIAN)
@@ -141,7 +135,6 @@ def test_weeknum
141135
end
142136

143137
def test_weeknum__2
144-
skip unless defined?(Calendar)
145138
for j in @from4t..@to4t
146139
d = Date.jd(j)
147140
t = Time.mktime(d.year, d.mon, d.mday)
@@ -159,7 +152,6 @@ def test_weeknum__2
159152
end
160153

161154
def test_nth_kday
162-
skip unless defined?(Calendar)
163155
skip unless (Date.respond_to?(:nth_kday_to_jd, true) &&
164156
Date.respond_to?(:jd_to_nth_kday, true))
165157
for y in 1601..2401
@@ -440,4 +432,4 @@ def test_valid_time
440432
assert_nil(DateTime.__send__(valid_time_p, 24,1,1))
441433
end
442434

443-
end
435+
end if defined?(Calendar)

test/date/test_date_new.rb

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,6 @@ def test_commercial__ex
203203
end
204204

205205
def test_weeknum
206-
skip unless Date.respond_to?(:weeknum, true)
207206
d = Date.__send__(:weeknum)
208207
dt = DateTime.__send__(:weeknum)
209208
assert_equal([-4712, 1, 1], [d.year, d.mon, d.mday])
@@ -223,10 +222,9 @@ def test_weeknum
223222
assert_raise(ArgumentError) do
224223
Date.__send__(:weeknum, 1999,-53,-1, 0)
225224
end
226-
end
225+
end if Date.respond_to?(:weeknum, true)
227226

228227
def test_nth_kday
229-
skip unless Date.respond_to?(:nth_kday, true)
230228
d = Date.__send__(:nth_kday)
231229
dt = DateTime.__send__(:nth_kday)
232230
assert_equal([-4712, 1, 1], [d.year, d.mon, d.mday])
@@ -246,7 +244,7 @@ def test_nth_kday
246244
assert_raise(ArgumentError) do
247245
Date.__send__(:nth_kday, 2006,5, -5,0)
248246
end
249-
end
247+
end if Date.respond_to?(:nth_kday, true)
250248

251249
def test_today
252250
z = Time.now

test/date/test_switch_hitter.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -658,8 +658,7 @@ def test_dup
658658
end
659659

660660
def test_base
661-
skip unless defined?(Date.test_all)
662661
assert_equal(true, Date.test_all)
663-
end
662+
end if defined?(Date.test_all)
664663

665664
end

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy