Remove unneeded test-all skips, based on 34739 by nobu #1743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkn
pushed a commit
to mrkn/ruby
that referenced
this pull request
Dec 1, 2017
…defined. Revisit r34739. Patch by MSP-Greg. [Bug #14088][ruby-core:83690][fix rubyGH-1743] git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@60734 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing test-all results, several skips were listed from the test/date files. A few years ago, @nobu commited svn 34739, which was reverted (possibly due to rdoc changes?).
This PR uses just the date specific patches. Old methods and require 'calendar'...
See https://bugs.ruby-lang.org/issues/14088