Skip to content

Handle void expressions in defined? #12949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

Handle void expressions in defined? #12949

merged 1 commit into from
Mar 18, 2025

Conversation

kddnewton
Copy link
Contributor

[Bug #21029]

@kddnewton kddnewton merged commit adaaa78 into ruby:master Mar 18, 2025
76 checks passed
@kddnewton kddnewton deleted the void-expr-defined branch March 18, 2025 18:44
S-H-GAMELINKS added a commit to S-H-GAMELINKS/ruby that referenced this pull request Jul 8, 2025
@S-H-GAMELINKS
Make defined? (x;) return expression when using parse.y parser
e1a6db0 
Follow up [Bug #21029].

Currently,  `defined? (x;)` returns `expression` when using Prism parser.

See:
- ruby#12949
- https://bugs.ruby-lang.org/issues/21029

However, `defined? (x;)` returns nil when using parse.y, as reported in bug ticket comment and test-all (when using parse.y parser) test result.

This change adds a context flag to track trailing semicolons in defined? scope.
When a trailing semicolon is detected within a defined? scope, the generated AST node is wrapped with NODE_BLOCK.
This change ensures consistent behavior with `defined? (;x)` .
@S-H-GAMELINKS S-H-GAMELINKS mentioned this pull request Jul 8, 2025
Merged
S-H-GAMELINKS added a commit to S-H-GAMELINKS/ruby that referenced this pull request Jul 9, 2025
@S-H-GAMELINKS
Make defined? (x;) return expression when using parse.y parser
26d5e9e 
Follow up [Bug #21029].

Currently,  `defined? (x;)` returns `expression` when using Prism parser.

See:
- ruby#12949
- https://bugs.ruby-lang.org/issues/21029

However, `defined? (x;)` returns nil when using parse.y, as reported in bug ticket comment and test-all (when using parse.y parser) test result.

This change adds a context flag to track trailing semicolons in defined? scope.
When a trailing semicolon is detected within a defined? scope, the generated AST node is wrapped with NODE_BLOCK.
This change ensures consistent behavior with `defined? (;x)` .
S-H-GAMELINKS added a commit to S-H-GAMELINKS/ruby that referenced this pull request Jul 9, 2025
@S-H-GAMELINKS
Make defined? (x;) return expression when using parse.y parser
927797b 
Follow up [Bug #21029].

Currently,  `defined? (x;)` returns `expression` when using Prism parser.

See:
- ruby#12949
- https://bugs.ruby-lang.org/issues/21029

However, `defined? (x;)` returns nil when using parse.y, as reported in bug ticket comment and test-all (when using parse.y parser) test result.

This change adds a context flag to track trailing semicolons in defined? scope.
When a trailing semicolon is detected within a defined? scope, the generated AST node is wrapped with NODE_BLOCK.
This change ensures consistent behavior with `defined? (;x)` .
S-H-GAMELINKS added a commit to S-H-GAMELINKS/ruby that referenced this pull request Jul 10, 2025
@S-H-GAMELINKS
Make defined? (x;) return expression when using parse.y parser
611879c 
Follow up [Bug #21029].

Currently,  `defined? (x;)` returns `expression` when using Prism parser.

See:
- ruby#12949
- https://bugs.ruby-lang.org/issues/21029

However, `defined? (x;)` returns nil when using parse.y, as reported in bug ticket comment and test-all (when using parse.y parser) test result.

This change adds a context flag to track trailing semicolons in defined? scope.
When a trailing semicolon is detected within a defined? scope, the generated AST node is wrapped with NODE_BLOCK.
This change ensures consistent behavior with `defined? (;x)` .
S-H-GAMELINKS added a commit to S-H-GAMELINKS/ruby that referenced this pull request Jul 11, 2025
@S-H-GAMELINKS
Make defined? (x;) return expression when using parse.y parser
7d1969d 
Follow up [Bug #21029].

Currently,  `defined? (x;)` returns `expression` when using Prism parser.

See:
- ruby#12949
- https://bugs.ruby-lang.org/issues/21029

However, `defined? (x;)` returns nil when using parse.y, as reported in bug ticket comment and test-all (when using parse.y parser) test result.

This change adds a context flag to track trailing semicolons in defined? scope.
When a trailing semicolon is detected within a defined? scope, the generated AST node is wrapped with NODE_BLOCK.
This change ensures consistent behavior with `defined? (;x)` .
nobu pushed a commit that referenced this pull request Jul 16, 2025
@S-H-GAMELINKS @nobu
Make defined? (x;) return expression when using parse.y parser
f0649ab 
Follow up [Bug #21029].

Currently,  `defined? (x;)` returns `expression` when using Prism parser.

See:
- #12949
- https://bugs.ruby-lang.org/issues/21029

However, `defined? (x;)` returns nil when using parse.y, as reported in bug ticket comment and test-all (when using parse.y parser) test result.

This change adds a context flag to track trailing semicolons in defined? scope.
When a trailing semicolon is detected within a defined? scope, the generated AST node is wrapped with NODE_BLOCK.
This change ensures consistent behavior with `defined? (;x)` .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kddnewton
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy