Skip to content

[Bug #21256] Fix it parameter when splatting and define_method is used #13108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025

Conversation

Earlopain
Copy link
Contributor

https://bugs.ruby-lang.org/issues/21256

It was failing to set the leads, like numblocks do, causing the result to be wrapped in an array

@Earlopain Earlopain force-pushed the it-splat-define-method branch from 15584a8 to cbc5ecb Compare April 13, 2025 12:53
@Earlopain Earlopain closed this Apr 13, 2025
@Earlopain Earlopain force-pushed the it-splat-define-method branch from cbc5ecb to cfa74dd Compare April 13, 2025 13:10
… used

It was failing to set the leads, like numblocks do, causing the result to be wrapped in an array
@Earlopain Earlopain reopened this Apr 13, 2025
@mame mame requested a review from kddnewton May 7, 2025 07:03
@tenderlove tenderlove enabled auto-merge (rebase) July 17, 2025 19:46
@tenderlove tenderlove merged commit 2650596 into ruby:master Jul 17, 2025
81 of 83 checks passed
@mame
Copy link
Member

mame commented Jul 18, 2025

@Earlopain @tenderlove Sorry but this change caused an ASAN error. I would like to revert this for now. See #13947.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy