Skip to content

Fix early write barrier rb_marshal_define_compat #13631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

Fix early write barrier rb_marshal_define_compat #13631

merged 1 commit into from
Jun 17, 2025

Conversation

jhawthorn
Copy link
Member

I found this using my wbcheck tool (See #13557)

WBCHECK ERROR: Missed write barrier detected!
  Parent object: 0x64a8bb6cee40 (wb_protected: true)
    rb_obj_info_dump: 0x000064a8bb6cee40 marshal_compat_table/marshal_compat_table
  Reference counts - snapshot: 7, writebarrier: 2, current: 11, missed: 1
  Missing reference to: 0x64a8bb87dfd0
    rb_obj_info_dump: 0x000064a8bb87dfd0 T_CLASS/Process::Status

This write barrier occurred before the entry was added to the table, so if GC occurred when inserting into the table, the write could be missed.

Similar to #13629

@jhawthorn
Fix early write barrier rb_marshal_define_compat
c596399 
This write barrier occurred before the entry was added to the table, so
if GC occurred when inserting into the table, the write could be missed.
@jhawthorn jhawthorn merged commit c6a6645 into ruby:master Jun 17, 2025
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobu nobu nobu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhawthorn @nobu
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy