Skip to content

Optimize String#casecmp? for ASCII-only strings #13711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+13 −3
Open

Optimize String#casecmp? for ASCII-only strings #13711

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6190e8a
Optimize String#casecmp? for ASCII
sferik Jun 26, 2025
f774071
Only implement this optimization for strings under 120 characters
sferik Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Optimize String#casecmp? for ASCII
  • Loading branch information
@sferik
sferik committed Jun 30, 2025
commit 6190e8a41dbace37e203845e4b34ba11c088e519
11 changes: 8 additions & 3 deletions string.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4443,16 +4443,21 @@ static VALUE
str_casecmp_p(VALUE str1, VALUE str2)
{
rb_encoding *enc;
VALUE folded_str1, folded_str2;
VALUE fold_opt = sym_fold;

enc = rb_enc_compatible(str1, str2);
if (!enc) {
return Qnil;
}

folded_str1 = rb_str_downcase(1, &fold_opt, str1);
folded_str2 = rb_str_downcase(1, &fold_opt, str2);
if (ENC_CODERANGE(str1) == ENC_CODERANGE_7BIT &&
ENC_CODERANGE(str2) == ENC_CODERANGE_7BIT) {
VALUE cmp = str_casecmp(str1, str2);
return RBOOL(cmp == INT2FIX(0));
}

VALUE folded_str1 = rb_str_downcase(1, &fold_opt, str1);
VALUE folded_str2 = rb_str_downcase(1, &fold_opt, str2);

return rb_str_eql(folded_str1, folded_str2);
}
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy