Allow concurrent use of system(), IO.popen and Process.spawn in ractors #13806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Tests Failed✖️no tests failed ✔️62052 tests passed(1 flake) |
These ruby methods call `fork` or `vfork` internally, so we need to grab the fork lock in the parent and release it after the call. We don't reset the lock in the child because we're going to exec right after anyway. Without this lock, strange things were happening having to do with the timer thread. Sometimes multiple timers were running.
84be09a to
6912825
Compare
|
Some CI failures right now. It looks like the added test may be triggering a ractor bug that we already know about that has a PR but has not been merged yet. I'll continue to investigate. |
|
Hmm. The test doesn't reproduce for me (at least on linux, testing macos...). I feel like we shouldn't need the fork lock for these operations because we're going to exec immediately after and so whatever inconsistency that was trying to avoid shouldn't be an issue (but maybe there is some problem before the |
|
You're right, sorry! Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These ruby methods call
forkorvforkinternally, so we need to grab the fork lock in the parent and release it after the call. We don't reset the lock in the child because we're going to exec right after anyway. Without this lock, strange things were happening having to do with the timer thread. Sometimes multiple timers were running.