Skip to content

[Bug #21513] Raise on converting endless range to set #13902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Bug #21513] Raise on converting endless range to set #13902

wants to merge 1 commit into from
+22 −0

Conversation

viralpraxis
Copy link
Contributor

@viralpraxis viralpraxis commented Jul 15, 2025 •
edited
Loading

Before this patch, trying to convert endless range (e.g. (1..) or any other inifinte enumerable) to set (using to_set) would hang

jeremyevans
jeremyevans requested changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

@viralpraxis viralpraxis force-pushed the raise-on-endless-range-to-set branch 2 times, most recently from 4b9f122 to 31a3861 Compare July 15, 2025 22:33
@viralpraxis
Copy link
Contributor Author

There's a SEGV in the ZJIT test suite: https://github.com/ruby/ruby/actions/runs/16305765996/job/46051383888?pr=13902

Not sure if it's related to my changes

@viralpraxis viralpraxis force-pushed the raise-on-endless-range-to-set branch from 31a3861 to a5a7db6 Compare July 15, 2025 22:52
@tekknolagi
Copy link
Contributor

There's a SEGV in the ZJIT test suite: https://github.com/ruby/ruby/actions/runs/16305765996/job/46051383888?pr=13902

Not sure if it's related to my changes

ZJIT error seems entirely unrelated to your change from a quick glance

@tekknolagi
Copy link
Contributor

Looks like a weird GC issue related to marking though so paging in @k0kubun for good measure

nobu
nobu reviewed Jul 15, 2025
View reviewed changes
@viralpraxis viralpraxis force-pushed the raise-on-endless-range-to-set branch from a5a7db6 to e1b6f53 Compare July 15, 2025 23:39
@viralpraxis viralpraxis changed the title [Feature #21513] Raise on converting endless range to set [Bug #21513] Raise on converting endless range to set Jul 15, 2025
@viralpraxis viralpraxis force-pushed the raise-on-endless-range-to-set branch from e1b6f53 to ca35402 Compare July 15, 2025 23:40
@launchable-app Launchable app

This comment has been minimized.

Sign in to view
@k0kubun
Copy link
Member

k0kubun commented Jul 16, 2025 •
edited
Loading

I agree that it's probably not related to the changes. We're looking into GC issues with ZJIT.

@viralpraxis viralpraxis force-pushed the raise-on-endless-range-to-set branch 6 times, most recently from 7753557 to 2de1bf0 Compare July 19, 2025 10:47
@viralpraxis
Copy link
Contributor Author

Could someone please take a look?

@viralpraxis viralpraxis force-pushed the raise-on-endless-range-to-set branch from 2de1bf0 to 36e3cee Compare July 24, 2025 11:14
@viralpraxis viralpraxis requested review from jeremyevans and nobu July 24, 2025 11:15
jeremyevans
jeremyevans requested changes Jul 24, 2025
View reviewed changes
@viralpraxis viralpraxis force-pushed the raise-on-endless-range-to-set branch from 36e3cee to f9dce06 Compare July 24, 2025 13:48
@viralpraxis
Copy link
Contributor Author

@jeremyevans thank you very much for helping me with that! ❤️

@viralpraxis viralpraxis force-pushed the raise-on-endless-range-to-set branch 2 times, most recently from 77d1e01 to 2241e74 Compare July 27, 2025 13:19
@viralpraxis
Copy link
Contributor Author

CI failures are unrelated:

   TestGemRequest#test_verify_certificate_extra_message:
  Test::Unit::ProxyError: X509_dup
      /home/runner/work/ruby/ruby/src/lib/rubygems/request.rb:92:in 'OpenSSL::X509::StoreContext#current_cert'
      /home/runner/work/ruby/ruby/src/lib/rubygems/request.rb:92:in 'Gem::Request.verify_certificate'
      /home/runner/work/ruby/ruby/src/test/rubygems/test_gem_request.rb:373:in 'block in TestGemRequest#test_verify_certificate_extra_message'
      /home/runner/work/ruby/ruby/src/lib/rubygems/user_interaction.rb:46:in 'Gem::DefaultUserInteraction.use_ui'
      /home/runner/work/ruby/ruby/src/lib/rubygems/user_interaction.rb:69:in 'Gem::DefaultUserInteraction#use_ui'
      /home/runner/work/ruby/ruby/src/test/rubygems/test_gem_request.rb:372:in 'TestGemRequest#test_verify_certificate_extra_message'

@viralpraxis
[Bug #21513] Raise on converting endless range to set
d8acf88 
ref: https://bugs.ruby-lang.org/issues/21513

Before this patch, trying to convert endless range (e.g. `(1..)`) to set
(using `to_set`) would hang
@viralpraxis viralpraxis force-pushed the raise-on-endless-range-to-set branch from 2241e74 to d8acf88 Compare July 27, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knu knu knu left review comments

@jeremyevans jeremyevans jeremyevans approved these changes

@nobu nobu Awaiting requested review from nobu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@viralpraxis @tekknolagi @k0kubun @jeremyevans @knu @nobu
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy