Skip to content

ZJIT: Give up JIT-to-JIT calls for 6+ args #13939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

ZJIT: Give up JIT-to-JIT calls for 6+ args #13939

merged 1 commit into from
Jul 17, 2025

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Jul 17, 2025 •
edited
Loading

This PR fixes the following panic on blurhash benchmark:

thread '<unnamed>' panicked at zjit/src/backend/x86_64/mod.rs:349:21:
assertion failed: opnds.len() <= C_ARG_OPNDS.len()

Since our current asm.ccall() supports only six arguments, we can't use SendWithoutBlockDirect that passes method params as arguments to asm.ccall(). Let's use SendWithoutBlock until we fix asm.ccall().

@k0kubun k0kubun marked this pull request as ready for review July 17, 2025 19:18
@matzbot matzbot requested a review from a team July 17, 2025 19:18
@k0kubun k0kubun mentioned this pull request Jul 17, 2025
Closed
@k0kubun k0kubun linked an issue Jul 17, 2025 that may be closed by this pull request
ZJIT: assertion failed: opnds.len() <= C_ARG_OPNDS.len() on blurhash Shopify/ruby#645
Closed
@k0kubun k0kubun merged commit 04d43e1 into ruby:master Jul 17, 2025
81 checks passed
@k0kubun k0kubun deleted the zjit-ccall-bail branch July 17, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekknolagi tekknolagi tekknolagi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZJIT: assertion failed: opnds.len() <= C_ARG_OPNDS.len() on blurhash
2 participants
@k0kubun @tekknolagi
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy