ZJIT: Run against all tests #13950
ZJIT: Run against all tests #13950
Conversation
de1124a to
a056a5a
Compare
/testa056a5a to
5fb6475
Compare
|
Can you explain the YAML changes please? I'm not sure the current description clears it up for me. There are too many suites and commands for me to keep track of. |
|
|
5fb6475 to
3a555cf
Compare
3a555cf to
688dbfc
Compare
zjit/src/codegen.rs
Outdated
| @@ -102,6 +102,10 @@ fn gen_iseq_entry_point(iseq: IseqPtr) -> *const u8 { | |||
| let cb = ZJITState::get_code_block(); | |||
| let code_ptr = gen_iseq_entry_point_body(cb, iseq); | |||
|
|
|||
| // REMOVE ME | |||
| // Just to test if the crash is related to write barriers | |||
| unsafe { rb_gc_writebarrier_remember(iseq.into()) }; | |||
There was a problem hiding this comment.
There was another one, too, somewhere else in this file
There was a problem hiding this comment.
I think in that commit the other change is unrelated:
- asm.cmp(val, Opnd::UImm(expected.into()));
+ asm.cmp(val, Opnd::Value(expected));
which has also been shipped in #13935
There was a problem hiding this comment.
No, I mean there was another call to remember
There was a problem hiding this comment.
I checked out back to the old commits, and the other 2 rb_gc_writebarrier_remember we added in pairing later became part of append_gc_offsets.
The other one in profile.rs was changed into rb_gc_writebarrier in #13935
make zjit-test-allnow runs all test under/test, which includes several default gems' tests/test/.excludes-zjit/zjit-test-alltakes quite a while, I think we can runzjit-checkinstead ofzjit-teston CI to get a faster feedback, even thotest_zjit.rbwill be run twice (another time inzjit-test-all)