ruby · sferik · Jul 18, 2025
diff --git a/internal/thread.h b/internal/thread.h
@@ -31,6 +31,9 @@ struct rb_io;
 #define COVERAGE_TARGET_ONESHOT_LINES 8
 #define COVERAGE_TARGET_EVAL 16
 
+#define THREAD_TIMER_INTERVAL_MSEC 10
+#define THREAD_TIMER_INTERVAL_USEC (THREAD_TIMER_INTERVAL_MSEC * 1000)
+
 #define RUBY_FATAL_THREAD_KILLED INT2FIX(0)
 #define RUBY_FATAL_THREAD_TERMINATED INT2FIX(1)
 #define RUBY_FATAL_FIBER_KILLED RB_INT2FIX(2)

diff --git a/thread.c b/thread.c
@@ -2683,7 +2683,7 @@ rb_threadptr_execute_interrupts(rb_thread_t *th, int blocking_timing)
                 limits_us >>= -th->priority;
 
             if (th->status == THREAD_RUNNABLE)
-                th->running_time_us += 10 * 1000; // 10ms = 10_000us // TODO: use macro
+                th->running_time_us += THREAD_TIMER_INTERVAL_USEC;
 
             VM_ASSERT(th->ec->cfp);
             EXEC_EVENT_HOOK(th->ec, RUBY_INTERNAL_EVENT_SWITCH, th->ec->cfp->self,

diff --git a/thread_pthread.c b/thread_pthread.c
@@ -13,6 +13,7 @@
 
 #include "internal/gc.h"
 #include "internal/sanitizers.h"
+#include "internal/thread.h"
 
 #ifdef HAVE_SYS_RESOURCE_H
 #include <sys/resource.h>
@@ -2888,7 +2889,7 @@ static int
 timer_thread_set_timeout(rb_vm_t *vm)
 {
 #if 0
-    return 10; // ms
+    return THREAD_TIMER_INTERVAL_MSEC;
 #else
     int timeout = -1;
 
@@ -2904,7 +2905,7 @@ timer_thread_set_timeout(rb_vm_t *vm)
                            !ubf_threads_empty(),
                            (vm->ractor.sched.grq_cnt > 0));
 
-            timeout = 10; // ms
+            timeout = THREAD_TIMER_INTERVAL_MSEC;
             vm->ractor.sched.timeslice_wait_inf = false;
         }
         else {
@@ -2926,7 +2927,7 @@ timer_thread_set_timeout(rb_vm_t *vm)
                 RUBY_DEBUG_LOG("th:%u now:%lu rel:%lu", rb_th_serial(th), (unsigned long)now, (unsigned long)hrrel);
 
                 // TODO: overflow?
-                timeout = (int)((hrrel + RB_HRTIME_PER_MSEC - 1) / RB_HRTIME_PER_MSEC); // ms
+                timeout = (int)((hrrel + RB_HRTIME_PER_MSEC - 1) / RB_HRTIME_PER_MSEC);
             }
         }
         rb_native_mutex_unlock(&timer_th.waiting_lock);

diff --git a/thread_win32.c b/thread_win32.c
@@ -12,9 +12,9 @@
 #ifdef THREAD_SYSTEM_DEPENDENT_IMPLEMENTATION
 
 #include "internal/sanitizers.h"
+#include "internal/thread.h"
 #include <process.h>
 
-#define TIME_QUANTUM_USEC (10 * 1000)
 #define RB_CONDATTR_CLOCK_MONOTONIC 1 /* no effect */
 
 #undef Sleep
@@ -774,7 +774,7 @@ timer_thread_func(void *dummy)
     RUBY_DEBUG_LOG("start");
     rb_w32_set_thread_description(GetCurrentThread(), L"ruby-timer-thread");
     while (WaitForSingleObject(timer_thread.lock,
-                               TIME_QUANTUM_USEC/1000) == WAIT_TIMEOUT) {
+                               THREAD_TIMER_INTERVAL_MSEC) == WAIT_TIMEOUT) {
         vm->clock++;
         rb_threadptr_check_signal(vm->ractor.main_thread);
     }

diff --git a/tool/lib/test/unit/assertions.rb b/tool/lib/test/unit/assertions.rb
@@ -799,7 +799,7 @@ def assert_no_warning(pat, msg = nil)
 
       def assert_cpu_usage_low(msg = nil, pct: 0.05, wait: 1.0, stop: nil)
         wait = EnvUtil.apply_timeout_scale(wait)
-        if wait < 0.1 # TIME_QUANTUM_USEC in thread_pthread.c
+        if wait < 0.1 # THREAD_TIMER_INTERVAL_USEC in thread.h
           warn "test #{msg || 'assert_cpu_usage_low'} too short to be accurate"
         end