symbol.c: simplify dup_string_for_create
#13971
Open
+79
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0a822e to
10cc341
Compare
This comment has been minimized.
This comment has been minimized.
`rb_fstring`, when passed a non-bare string (either a String subclass or a String with ivars), in some case it would just freeze it. That behavior only make sense for `String#-@`, and a few other places. But when used for things such as `String#to_sym` it requires a lot of checks on the caller part. `rb_bare_fstring` implement a simpler logic for this.
NB: `str` may be a fake string when the caller is `intern3` or similar. - Use `rb_bare_fstring`, which accept STR_FAKESTR and non-bare strings. - Check for ASCII strings with encindex. - Skip checking for ASCII compatibility. - Skip duping the string.
10cc341 to
befd510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB:
strmay be a fake string when the caller isintern3or similar.rb_bare_fstring, which accept STR_FAKESTR and non-bare strings.