ZJIT: Guide WB skipping for Insn::SetLocal using HIR type info #13978
+14
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
k0kubun
reviewed
Jul 22, 2025
zjit/src/codegen.rs
Outdated
| @@ -353,7 +353,7 @@ fn gen_insn(cb: &mut CodeBlock, jit: &mut JITState, asm: &mut Assembler, functio | |||
| Insn::SetGlobal { id, val, state: _ } => return Some(gen_setglobal(asm, *id, opnd!(val))), | |||
| Insn::GetGlobal { id, state: _ } => gen_getglobal(asm, *id), | |||
| &Insn::GetLocal { ep_offset, level } => gen_getlocal_with_ep(asm, ep_offset, level)?, | |||
| Insn::SetLocal { val, ep_offset, level } => return gen_setlocal_with_ep(asm, opnd!(val), *ep_offset, *level), | |||
| &Insn::SetLocal { val, ep_offset, level } => return gen_setlocal_with_ep(asm, opnd!(val), function.is_a(val, types::Immediate), ep_offset, level), | |||
There was a problem hiding this comment.
function.is_a(val, types::Immediate)
I feel like this kind of type checking (not just fetching the type, but checking that it's "immediate") should be part of the codegen logic (i.e. live inside gen_setlocal_with_ep()). You generally wouldn't want to go back and forth between gen_insn() and gen_setlocal_with_ep() too often when you read/write the logic of codegen.
One way to do that would be to give val_type: Type as an argument. Another way would be to just pass around a reference to function (which seems fine to me) if we want to use the Function::is_a API.
|
Now this crashes when marking an Iseq: This could be some bad HIR optimization or some other GC bug... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tweak the opnd!() macro so that it works with both an
&InsnIdandan
InsnId.Following discussions in #13977